post processing: check for finding being None#12713
Merged
Maffooch merged 1 commit intoJun 30, 2025
Merged
Conversation
|
No security concerns detected in this pull request. All finding details can be found in the DryRun Security Dashboard. |
valentijnscholten
changed the title
Maffooch
approved these changes
Jun 30, 2025
hblankenship
approved these changes
Jun 30, 2025
dogboat
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11958
Sometimes during unit tests we see that the
findingis already deleted once thepost_process_finding_saveis being executed.This can also happen in real life if a finding is deleted manually or by the duplicate delete job.
This PR add a check so that the logs aren't polluted with stacktraces. There is still logging at the
warninglevel as it's not 100% expected/intended to have this happening.